-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Table] Add some props to patch css only style overrides #2246
Conversation
@@ -27,6 +27,9 @@ const Table = React.createClass({ | |||
selectable: React.PropTypes.bool, | |||
style: React.PropTypes.object, | |||
wrapperStyle: React.PropTypes.object, | |||
headerTableInlineStyle: React.PropTypes.object, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the Inline
part of the name to use the same convention as other component?
I also think that Table
is not needed.
Could you also add those to the documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda wanted the naming to be consistent with css classes, hence the inline
.
The Table
part is to avoid confusion with this:
<Table bodyStyle={...}>
...
<TableBody style={...}>
But there are more cases like this around the library.
If you are ok with those I'll change the names and squash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda wanted the naming to be consistent with css classes
I think that the css classes shouldn't be here, let's forget that they exist.
Your example looks good to me.
cb1fad8
to
adbc82e
Compare
@oliviertassinari All done. |
Thanks. Could you also add them to the documentation (in an alphabetic order)? |
Alright I'll do that too. but then we'll have to support them for some time 😅 |
adbc82e
to
1eaecc1
Compare
@oliviertassinari Is this ok? |
That's already the case for the className api. So I think it's better to have it documented. What better solution do you have in mind ? |
I'd say rewrite table, it's better not to use HTML But I guess if we decide to do this we have to rewrite all the table components. Therefore, deprecation will be very hard. The best solution I can come up with is:
|
@subjectix Thanks. |
[Table] Add some props to patch css only style overrides
These elements can only be styled through css classes. This PR temporary patches this component until we come up with a better solution than all these nested
div
s andtable
s. I won't add documentation since this is probably only temporary so people can have some way of overriding these elements without having to resort to css classes.