-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[framer] Fix Avatar imageFile & imageUrl #21887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should change the callsites of Avatar
as well (e.g. in Chip.tsx). #21868 will include this and verify that the fix is correct.
Hmm, right. Perhaps there's a better way to do it so that the prop name doesn't change. A transform from componentNamePropName to propName in the build script perhaps? |
I have seen a couple of pull requests around Framer lately. Should we care enough to spend time on improving the bindings? From the last survey https://uxtools.co/survey-2019/, and looking at the traffic on the tool, the tools seem to be marginally used compared to the alternatives. |
Time is already spent. But if it's not important I'll de-prioritize in the future. There is considerable technical debt in those files so we might want to consider removing them from the repo if the cost grows to high. |
I would be interested in resolving this question. How much effort do we want to dedicate to the framer assets? Outside of the market shares of framer, I have also noticed that our asset isn't that much popular on their store, while we are on the first line, we wouldn't be if the list was ranked by stars or downloads: https://packages.framer.com/. Maybe there is a quick opportunity, shouldn't we rank for the query "material design" https://packages.framer.com/?q=material%20design? |
We should keep in mind that they currently have some bugs/TS issues. Context for data is important. |
#21868 (comment)