-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new component] auto-complete #2187
Conversation
return ( | ||
<ComponentDoc | ||
name="Auto Complete" | ||
componentInfo={[{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add more information as for instance here https://github.com/callemall/material-ui/blob/master/docs/src/app/components/pages/components/dialog.jsx#L31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to, just quite busy recently. I can do it this friday. I thought maybe we should push it first and then finish it? Since the component is usable, I wish more people can try it out before the document is ready.
@oliviertassinari @shaurya947 It should be ready now :) |
@@ -0,0 +1,45 @@ | |||
<AutoComplete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the extra spaces?
@yongxu The API looks good to me 👍. Could you have a look at my comment? I will merge then. |
non-unidirectional data flow pattern is removed, in order to fit flux model. Now dataSource accept object {key:component} pattern Improved performance.
3e6a566
to
07919d1
Compare
[AutoComplete] Add this new component
@yongxu Thanks for your effort! |
Thanks for all the review @oliviertassinari 👍 |
@yongxu @oliviertassinari @shaurya947 👍 |
Yes! |
This component is the latest update from #1985
I decided to open a new PR because of the name change.
Known bug:
from @vijayrawatsan:
This might be caused by bug from src/menus/menu.jsx
@oliviertassinari the api has been changed to:
Please merge, it should be ready! :)