icon-menu using popover #2149
icon-menu using popover #2149
Conversation
| closeOnItemTouchTap: React.PropTypes.bool, | ||
| iconButtonElement: React.PropTypes.element.isRequired, | ||
| iconStyle: React.PropTypes.object, | ||
| openDirection: PropTypes.corners, | ||
| menuOverlapsIcon: React.PropTypes.bool, |
There was a problem hiding this comment.
Seems to me that you are not using menuOverlapsIcon
|
I have noticed one issue, the |
oliviertassinari
added
PR: needs revision
|
@oliviertassinari this one is good to review again |
oliviertassinari
added
Review: review-needed
and removed
PR: needs revision
| @@ -279,8 +279,9 @@ export default class IconMenus extends React.Component { | |||
| <div> | |||
| <IconMenu | |||
| iconButtonElement={mapsButtonElement} | |||
| maxHeight={272} | |||
| openDirection="bottom-right" | |||
There was a problem hiding this comment.
Could you remove openDirection form the doc and add the new properties?
There was a problem hiding this comment.
+1 for updating the docs, I had hard time before finding this
|
@chrismcv It's almost ready to be merged 👍. |
|
@oliviertassinari should be good now |
|
@chrismcv Thanks |
[icon-menu] Use popover component
|
I have just noticed one issue. I feel like there is a delay between a tap on an item and the closing of the menu. Do you confirm? |
|
It may be linked to touchTapCloseDelay. I will investigat tomorrow |
|
Actually, it takes time to disappear when the component is unmounted. |
|
I think the issue is that the Level 1 menu is starting to animate its close (caused by |
|
@oliviertassinari gotcha. Next release we'll bump the minor version. |
zannager
added
component: menu
Reworked from #1845
This means an icon-menu in a dialog can break outside it if needs be