Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Improve de-DE locale #20684

Merged
merged 1 commit into from
Apr 23, 2020
Merged

[l10n] Improve de-DE locale #20684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions packages/material-ui/src/locale/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,9 @@ export const csCZ = {

export const deDE = {
props: {
// MuiBreadcrumbs: {
// expandText: 'Show path',
// },
MuiBreadcrumbs: {
expandText: 'Pfad anzeigen',
},
MuiTablePagination: {
backIconButtonText: 'Nächste Seite',
labelRowsPerPage: 'Zeilen pro Seite:',
Expand All @@ -224,7 +224,7 @@ export const deDE = {
},
MuiRating: {
getLabelText: (value) => `${value} ${value !== 1 ? 'Sterne' : 'Stern'}`,
emptyLabelText: 'Empty',
emptyLabelText: 'Keine Wertung',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the correct translation. "Empty" is pretty meaningless. Is there more context? How would this be displayed?

Copy link
Member

@oliviertassinari oliviertassinari Apr 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can have more context on https://www.w3.org/WAI/tutorials/forms/custom-controls/#a-star-rating, the label goes instead of 0 Stars in the above link.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we should improve Empty as well. Seems like "No Rating" would have actual meaning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on how generic we want to be. Sounds fair.

},
MuiAutocomplete: {
clearText: 'Leeren',
Expand All @@ -236,27 +236,27 @@ export const deDE = {
MuiAlert: {
closeText: 'Schließen',
},
// MuiPagination: {
// 'aria-label': 'Pagination navigation',
// getItemAriaLabel: (type, page, selected) => {
// if (type === 'page') {
// return `${selected ? '' : 'Go to '}page ${page}`;
// }
// if (type === 'first') {
// return 'Go to first page';
// }
// if (type === 'last') {
// return 'Go to last page';
// }
// if (type === 'next') {
// return 'Go to next page';
// }
// if (type === 'previous') {
// return 'Go to previous page';
// }
// return undefined;
// },
// },
MuiPagination: {
'aria-label': 'Navigation via Seitennummerierung',
getItemAriaLabel: (type, page, selected) => {
if (type === 'page') {
return `${selected ? '' : 'Gehe zu '}Seite ${page}`;
}
if (type === 'first') {
return 'Zur ersten Seite';
}
if (type === 'last') {
return 'Zur letzten Seite';
}
if (type === 'next') {
return 'Zur nächsten Seite';
}
if (type === 'previous') {
return 'Zur vorherigen Seite';
}
return undefined;
},
},
},
};

Expand Down