Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable lint as part of build process #1862

Closed
wants to merge 1 commit into from
Closed

Conversation

bdefore
Copy link

@bdefore bdefore commented Oct 11, 2015

there are a bunch of linting errors that break npm run build right now

@oliviertassinari
Copy link
Member

You can close this issue/PR. The CI tool is linting the code and everything is fine.
I'm preaty sure this fail for you because you have an other .eslintrc higher in the directory hierarchy.

@bdefore
Copy link
Author

bdefore commented Oct 11, 2015

@oliviertassinari Is the CI linting though? I see the most recent running tests but not linting: https://travis-ci.org/callemall/material-ui/builds/84334520

@oliviertassinari
Copy link
Member

@bdefore Yes he does #979. The prepublish script is doing it.

prepublish: Run BEFORE the package is published. (Also run on local npm install without any arguments.)

(https://docs.npmjs.com/misc/scripts)

Plus, the failing lint rule that you described isn't enforced by the .eslintrc of this project.

@chrismcv
Copy link
Contributor

any thoughts on disabling linting on the docs project - when I'm coding I find it really slows things down when you need to go back and add dangling comma's and other incidentals that don't matter at dev time...

@oliviertassinari
Copy link
Member

@chrismcv Are you talking about the webpack-eslint pluggin? Then, I would suggest to enable the fix option so that eslint fix dangling comma's for you.

@oliviertassinari
Copy link
Member

@chrismcv Since #1887 solve it, can you close this PR?

@chrismcv
Copy link
Contributor

@bdefore - I can't close, can you?

@oliviertassinari
Copy link
Member

@chrismcv Sorry, @bdefore

@bdefore bdefore closed this Oct 16, 2015
@zannager zannager added the package: system Specific to @mui/system label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants