[Backdrop] Comment on z-index use case #18589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems very strange to me that you would want the zIndex of the Backdrop to be -1. I would think the backdrop zIndex should be 1 so it overrides any normally positioned or fixed positioned element on the page. I am seeing strange issues with the default backdrop where some elements on the page (also MUI components) are shown above it. The -1 seems to be the culprit. If you aren't going to change to 1, can someone explain why -1 is desirable? Thanks.
|
No bundle size changes comparing 7a329c5...a33a42d |
|
@meebix Do you have a codesandbox we can have a look at? |
oliviertassinari
changed the title
oliviertassinari
added
component: backdrop
|
For context, the z-index: -1 is important for dialog body scroll support. |
oliviertassinari
changed the title
oliviertassinari
approved these changes
Nov 28, 2019
|
Happy to follow up on this topic is needed. |
This was referenced Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems very strange to me that you would want the zIndex of the Backdrop to be -1. I would think the backdrop zIndex should be 1 so it overrides any normally positioned or fixed positioned element on the page. I am seeing strange issues with the default backdrop where some elements on the page (also MUI components, like Paper) are shown above it.
The -1 seems to be the culprit.
If you aren't going to change to 1, can someone explain why -1 is desirable?
Thanks.