Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add dynamic class name TS demo #17793

Merged
merged 1 commit into from
Oct 9, 2019
Merged

[docs] Add dynamic class name TS demo #17793

merged 1 commit into from
Oct 9, 2019

Conversation

lksilva
Copy link
Contributor

@lksilva lksilva commented Oct 8, 2019

No description provided.

@mui-pr-bot
Copy link

No bundle size changes comparing daadbca...cc2bdc9

Generated by 🚫 dangerJS against cc2bdc9

@joshwooding joshwooding added docs Improvements or additions to the documentation typescript labels Oct 8, 2019
import Switch from '@material-ui/core/Switch';

const useStyles = makeStyles({
button: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would approve but, I can’t remember if we include createStyles still. I would guess we still do but I’d have to check to be 100%

I’m on my phone atm but will check in a bit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we add it when the theme is used, it seems to be fine here.

import Switch from '@material-ui/core/Switch';

const useStyles = makeStyles({
button: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we add it when the theme is used, it seems to be fine here.

@eps1lon eps1lon mentioned this pull request Oct 9, 2019
@eps1lon eps1lon changed the title [docs] Add dynamic class name demos in ts [docs] Add dynamic class name TS demo Oct 9, 2019
@eps1lon eps1lon merged commit 882a74c into mui:master Oct 9, 2019
@eps1lon
Copy link
Member

eps1lon commented Oct 9, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants