Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popper] Fix placement update logic #17781

Merged
merged 2 commits into from
Oct 9, 2019
Merged

[Popper] Fix placement update logic #17781

merged 2 commits into from
Oct 9, 2019

Conversation

hoop71
Copy link
Contributor

@hoop71 hoop71 commented Oct 8, 2019 •
edited by oliviertassinari
Loading

This PR address the placement argument not being updated as described in issue

Closes #17309

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 8, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 59231d4...eef56ed

bundle Size Change Size Gzip Change Gzip
LinearProgress -- 65.3 kB -- 20.3 kB
@material-ui/core[umd] ▲ +16 B (+0.01% ) 306 kB ▼ -7 B (-0.01% ) 88 kB
Link -- 66.6 kB -- 21 kB
@material-ui/core ▲ +25 B (+0.01% ) 347 kB -- 94.9 kB
List -- 62.4 kB -- 19.3 kB
Popper ▲ +25 B (+0.09% ) 28.3 kB ▼ -1 B (-0.01% ) 10.2 kB
@material-ui/styles -- 51.8 kB -- 15.6 kB
@material-ui/system -- 15.7 kB -- 4.35 kB
AppBar -- 63.9 kB -- 19.9 kB
Avatar -- 62.7 kB -- 19.6 kB
Backdrop -- 67.7 kB -- 20.9 kB
Badge -- 65.3 kB -- 20.2 kB
BottomNavigation -- 62.4 kB -- 19.5 kB
BottomNavigationAction -- 75.3 kB -- 23.7 kB
Box -- 70.8 kB -- 21.3 kB
Breadcrumbs -- 68 kB -- 21.3 kB
Button -- 79.2 kB -- 24.5 kB
ButtonBase -- 73.8 kB -- 23.1 kB
ButtonGroup -- 64.2 kB -- 20 kB
Card -- 62.9 kB -- 19.6 kB
CardActionArea -- 74.9 kB -- 23.6 kB
CardActions -- 62 kB -- 19.3 kB
CardContent -- 62 kB -- 19.3 kB
CardHeader -- 65.1 kB -- 20.4 kB
CardMedia -- 62.4 kB -- 19.5 kB
Checkbox -- 81.6 kB -- 25.6 kB
Chip -- 70.6 kB -- 21.8 kB
CircularProgress -- 64.1 kB -- 20.1 kB
ClickAwayListener -- 3.85 kB -- 1.55 kB
Collapse -- 67.8 kB -- 20.9 kB
colorManipulator -- 3.83 kB -- 1.52 kB
Container -- 63.1 kB -- 19.6 kB
CssBaseline -- 57.6 kB -- 18 kB
Dialog -- 82.5 kB -- 25.5 kB
DialogActions -- 62.1 kB -- 19.4 kB
DialogContent -- 62.2 kB -- 19.4 kB
DialogContentText -- 64 kB -- 20 kB
DialogTitle -- 64.3 kB -- 20.1 kB
Divider -- 62.6 kB -- 19.6 kB
docs.landing -- 54.3 kB -- 14.3 kB
Drawer -- 84.4 kB -- 26 kB
ExpansionPanel -- 71.1 kB -- 22.1 kB
ExpansionPanelActions -- 62.1 kB -- 19.4 kB
ExpansionPanelDetails -- 61.9 kB -- 19.3 kB
ExpansionPanelSummary -- 77.9 kB -- 24.5 kB
Fab -- 76.6 kB -- 23.8 kB
Fade -- 23.1 kB -- 8.03 kB
FilledInput -- 72.9 kB -- 22.6 kB
FormControl -- 64.3 kB -- 19.9 kB
FormControlLabel -- 65.5 kB -- 20.5 kB
FormGroup -- 62 kB -- 19.3 kB
FormHelperText -- 63.3 kB -- 19.7 kB
FormLabel -- 63.2 kB -- 19.5 kB
Grid -- 65.1 kB -- 20.3 kB
GridList -- 62.5 kB -- 19.5 kB
GridListTile -- 63.7 kB -- 19.9 kB
GridListTileBar -- 63.2 kB -- 19.7 kB
Grow -- 23.7 kB -- 8.15 kB
Hidden -- 66.1 kB -- 20.6 kB
Icon -- 62.8 kB -- 19.6 kB
IconButton -- 76 kB -- 23.6 kB
Input -- 72 kB -- 22.4 kB
InputAdornment -- 65.1 kB -- 20.4 kB
InputBase -- 70.2 kB -- 22 kB
InputLabel -- 65.1 kB -- 20.2 kB
ListItem -- 77 kB -- 24 kB
ListItemAvatar -- 62.1 kB -- 19.3 kB
ListItemIcon -- 62.2 kB -- 19.4 kB
ListItemSecondaryAction -- 62 kB -- 19.3 kB
ListItemText -- 65 kB -- 20.3 kB
ListSubheader -- 62.8 kB -- 19.6 kB
Menu -- 88.3 kB -- 27.6 kB
MenuItem -- 78 kB -- 24.3 kB
MenuList -- 66 kB -- 20.5 kB
MobileStepper -- 67.7 kB -- 21 kB
Modal -- 14.3 kB -- 4.97 kB
NativeSelect -- 76.4 kB -- 24 kB
NoSsr -- 2.19 kB -- 1.04 kB
OutlinedInput -- 73.5 kB -- 22.8 kB
Paper -- 62.4 kB -- 19.3 kB
Popover -- 82.7 kB -- 25.4 kB
Portal -- 2.87 kB -- 1.29 kB
Radio -- 82.5 kB -- 25.9 kB
RadioGroup -- 63.2 kB -- 19.7 kB
Rating -- 69.8 kB -- 22.2 kB
RootRef -- 4.43 kB -- 1.67 kB
Select -- 113 kB -- 33.5 kB
Skeleton -- 62.5 kB -- 19.5 kB
Slide -- 25.1 kB -- 8.66 kB
Slider -- 74.9 kB -- 23.5 kB
Snackbar -- 77.1 kB -- 24 kB
SnackbarContent -- 65.8 kB -- 20.6 kB
SpeedDial -- 85.7 kB -- 26.9 kB
SpeedDialIcon -- 64.6 kB -- 20.2 kB
Step -- 62.6 kB -- 19.5 kB
StepButton -- 82.1 kB -- 25.7 kB
StepConnector -- 62.7 kB -- 19.6 kB
StepContent -- 68.9 kB -- 21.4 kB
StepIcon -- 64.7 kB -- 20.1 kB
StepLabel -- 68.6 kB -- 21.4 kB
Stepper -- 64.9 kB -- 20.3 kB
styles/createMuiTheme -- 16.2 kB -- 5.78 kB
Tabs -- 85.3 kB -- 27.1 kB
@material-ui/lab ▲ +25 B (+0.02% ) 144 kB ▲ +2 B (0.00% ) 45 kB
TextField -- 121 kB -- 35.4 kB
SpeedDialAction ▲ +25 B (+0.02% ) 115 kB ▲ +3 B (+0.01% ) 36.4 kB
SvgIcon -- 63 kB -- 19.6 kB
SwipeableDrawer -- 90.7 kB -- 28 kB
Switch -- 80.8 kB -- 25.1 kB
Tab -- 76.2 kB -- 24.1 kB
Table -- 62.4 kB -- 19.4 kB
TableBody -- 62.1 kB -- 19.3 kB
TableCell -- 64.1 kB -- 20 kB
TableFooter -- 62.1 kB -- 19.3 kB
TableHead -- 62.1 kB -- 19.3 kB
TablePagination -- 139 kB -- 40.6 kB
TableRow -- 62.5 kB -- 19.5 kB
TableSortLabel -- 77.2 kB -- 24.4 kB
TextareaAutosize -- 5.06 kB -- 2.11 kB
ToggleButton -- 76 kB -- 23.9 kB
docs.main ▲ +25 B (0.00% ) 598 kB ▼ -2 B (-0.00% ) 191 kB
ToggleButtonGroup -- 63.2 kB -- 19.8 kB
Toolbar -- 62.3 kB -- 19.4 kB
TreeItem -- 73.4 kB -- 23 kB
TreeView -- 66 kB -- 20.6 kB
Typography -- 63.6 kB -- 19.8 kB
useMediaQuery -- 2.49 kB -- 1.05 kB
Zoom -- 23.1 kB -- 8.04 kB
Tooltip ▲ +25 B (+0.03% ) 99 kB ▼ -3 B (-0.01% ) 31.3 kB

Generated by 🚫 dangerJS against eef56ed

@oliviertassinari oliviertassinari added the component: Popper The React component. See <Popup> for the latest version. label Oct 8, 2019
@oliviertassinari
Copy link
Member

@hoop71 I'm adding a new test.

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Oct 8, 2019
@oliviertassinari oliviertassinari changed the title [Popper] Render function placement argument is not updated [Popper] Fix placement update logic Oct 8, 2019
@oliviertassinari oliviertassinari merged commit d6f414b into mui:master Oct 9, 2019
@oliviertassinari
Copy link
Member

@hoop71 Thank you

@hoop71
Copy link
Contributor Author

hoop71 commented Oct 9, 2019

Thanks for the help! You and Material rock!

@toddmedema toddmedema mentioned this pull request Dec 22, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@joshwooding joshwooding joshwooding approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: Popper The React component. See <Popup> for the latest version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Popper] Render function placement argument is not updated
4 participants
@hoop71 @mui-pr-bot @oliviertassinari @joshwooding