[Documentation] Making Docs code eslint compliant #1778
Conversation
NogsMPLS
commented
Sep 30, 2015
NogsMPLS
commented
- Adding dangling commas where needed to make docs code pass eslint as defined in .eslintrc file.
- Removing 'module.export' and replacing with export default where applicable.
- Moving contextTypes to a static within component where applicable
- Changing single quoted props to double quote where applicable
- Adding spaces to arrays where applicable.
|
Look great! |
|
Any reason why on the wait? All changes are just es6 and lint changes, non are react specific. unless these changes conflict with docs in the react 0.14 branch? in which case, would you rather i apply these changes to that branch instead? |
|
On Thu, Oct 1, 2015 at 2:17 AM, Nathan Smith [email protected]
|
|
@NogsMPLS Our work with react v0.14 is almost done. We had to prioritize it over this PR. |
|
okay, lemme see if that worked. had quite a few merge conflicts, going through code committed now |
|
@NogsMPLS Thanks! Can you make eslint lint the docs source folder too, so that we prevent regression? Should be here https://github.com/callemall/material-ui/blob/master/gulpfile.js#L5. |
| super(); | ||
| static contextTypes = { | ||
| router: React.PropTypes.func, | ||
| }; |
There was a problem hiding this comment.
This needed anymore? Haven't been keeping up with changes, but I saw some router changes and other files changing contextTypes
There was a problem hiding this comment.
Yes, you can remove it.
|
docs folder added to eslint gulp task. just looking at jsx/js files since teh docs folder has that .txt thing going on with it. passing eslint on my machine. |
| @@ -2,12 +2,14 @@ const React = require('react'); | |||
| const ReactDOM = require('react-dom'); | |||
| const { Styles } = require('material-ui'); | |||
| const { Spacing } = Styles; | |||
| const { ThemeManager } = Styles; | |||
| const DefaultRawTheme = Styles.LightRawTheme; | |||
There was a problem hiding this comment.
eslint was throwing me an error later down the file because Thememanager and DefaultRawTheme weren't defined. looked at what the other files in docs were doing to handle it and slapped it in there.
There was a problem hiding this comment.
|
@shaurya947 I thinks that we can merge. |
|
@oliviertassinari but there's conflicts |
|
whaaat, there wasn't last night!!!! ill rebase again i suppose |
|
Okay, rebased, things should be good again |
[Documentation] Making Docs code eslint compliant
|
Thanks @NogsMPLS |
