[docs] Extend size-snapshot #17633
Merged
[docs] Extend size-snapshot #17633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/core: parsed: +3.41% , gzip: +3.84% Details of bundle changes.Comparing: 6905c58...860b997
|
eps1lon
commented
Sep 30, 2019
| - task: PublishPipelineArtifact@0 | ||
| inputs: | ||
| artifactName: 'size-snapshot' | ||
| targetPath: 'scripts/sizeSnapshot/build/stats.json' |
There was a problem hiding this comment.
I didn't use this for months. It takes now up to 1min extra CI time. Since they are only persisted for 30 days anyway and we can safely reproduce them (since we have a lockfile) if need be I removed it.
eps1lon
force-pushed
the
build/extended-snapshot
branch
from
baecc35 to
8ebfd66
Compare
eps1lon
force-pushed
the
build/extended-snapshot
branch
from
4c06c9d to
6080e95
Compare
There was a problem hiding this comment.
The cost is about +1 min in the build, seem ok, I expect we can parallelize it in the future if needed.
I have noticed the following in the report:
- /core/Paper is present twice, once with 0 reported size.
- A few items have a
/core/prefix (TextareaAutosize,useMediaQuery,Popper). Is this expected?
The snapshot that was removed is the commonJS version. Tracking the bundle size for commonJS is not that interesting since they are only used on server(less) targets.
Yeah but it's not really necessary. I'll remove it. |
they are unique anyway
oliviertassinari
approved these changes
Oct 2, 2019
|
Do you know why the reported size of |
Probably overhead from too many chunks. I don't like it either but having individual components tracked is IMO more useful than the bundle as a whole. Nobody (should) pull this in as a whole anyway.
I tend to not trust these. Everybody uses a different bundler/config so they're a bad advertising tool to begin with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New comparison table sorts by absolute diff making it easier to scan for changes
Track all components in core and lab. This should make their size snapshots a bit more stable with regards to chunks (we had some issues previously when a change in one dependency caused fluctuations for every tracked asset).
Running webpack separately on every bundle instead of declaring every bundle as an entry would be the most stable solution but increases time and is less representative of the change one sees when adding a given component to their app.
Labelled as docs since we link to it from some docs sites and I want to automate that process.
Future work: