Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Warn if anchor element is not visible #17599

Merged
merged 4 commits into from
Sep 29, 2019

Conversation

eAmin
Copy link
Contributor

@eAmin eAmin commented Sep 28, 2019

Due to @oliviertassinari recommendations at this issue we decided to submit this pull request.

Closes #17596

@croraf
Copy link
Contributor

croraf commented Sep 28, 2019

@eAmin Thanks for the PR. Have you tested the changes locally?

@oliviertassinari oliviertassinari added component: Popover The React component. component: Popper The React component. See <Popup> for the latest version. labels Sep 28, 2019
@eAmin
Copy link
Contributor Author

eAmin commented Sep 28, 2019

@croraf I'm really sorry, for the first time, no I don't, But after this pull request I fixed it and tested locally.
I wanted to delete this pull request and resend but I couldn't :)

@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: 77786f8...97f9ecb

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% +0.02% 🔺 332,477 332,485 90,700 90,719
@material-ui/core/Paper 0.00% 0.00% 68,882 68,882 20,527 20,527
@material-ui/core/Paper.esm 0.00% 0.00% 62,319 62,319 19,264 19,264
@material-ui/core/Popper +0.03% 🔺 +0.12% 🔺 28,397 28,405 10,160 10,172
@material-ui/core/Textarea 0.00% 0.00% 5,082 5,082 2,136 2,136
@material-ui/core/TrapFocus 0.00% 0.00% 3,766 3,766 1,596 1,596
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,348 16,348 5,818 5,818
@material-ui/core/useMediaQuery 0.00% 0.00% 2,488 2,488 1,050 1,050
@material-ui/lab +0.01% 🔺 -0.03% 143,344 143,352 43,803 43,792
@material-ui/styles 0.00% 0.00% 51,641 51,641 15,353 15,353
@material-ui/system 0.00% 0.00% 15,581 15,581 4,341 4,341
Button 0.00% 0.00% 78,719 78,719 24,031 24,031
Modal 0.00% 0.00% 14,542 14,542 5,113 5,113
Portal 0.00% 0.00% 2,907 2,907 1,318 1,318
Rating 0.00% 0.00% 70,185 70,185 21,915 21,915
Slider 0.00% 0.00% 75,326 75,326 23,248 23,248
colorManipulator 0.00% 0.00% 3,835 3,835 1,519 1,519
docs.landing 0.00% 0.00% 54,267 54,267 14,344 14,344
docs.main 0.00% 0.00% 581,912 581,920 186,264 186,269
packages/material-ui/build/umd/material-ui.production.min.js 0.00% +0.01% 🔺 303,293 303,304 87,259 87,264

Generated by 🚫 dangerJS against 97f9ecb

@oliviertassinari oliviertassinari added the new feature New feature or request label Sep 28, 2019
@oliviertassinari oliviertassinari changed the title Add warning to make sure the element is present in the document [core] Warn if anchor element is not visible Sep 28, 2019
@oliviertassinari oliviertassinari merged commit da26477 into mui:master Sep 29, 2019
@oliviertassinari
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Popover The React component. component: Popper The React component. See <Popup> for the latest version. new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu miss anchorEl position when scroll in virtualized list
4 participants