[Button] Increase elevation on hover when contained #17537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
design: material
Details of bundle changes.Comparing: cef3287...50cb921
|
|
My only concern with the related issue (#17493) is the customization story. I think that it's important to allow people to remove the elevation completely. I personny don't like this aspect of the Material Design guidelines. I find the Vuetify approach interesting, they allow to set elevation={0} to remove it: https://vuetifyjs.com/en/components/buttons#playground. I think that we could support it too, right now, it causes an issue with the Bootstrap theme on hover:
|
|
Seems like it's unrelated to this issue but related to elevation in general. The Disabling elevation is possible by overriding all the shadows in the theme. |
|
@eps1lon That's fair 👍 . |
eps1lon
force-pushed
the
fix/button/states-elevation
branch
from
aa144b2 to
9a88905
Compare
oliviertassinari
changed the title
oliviertassinari
approved these changes
Sep 24, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix of #17493
The color will be fixed once we figured out https://material.io/design/interaction/states.html. Previous work in #13134
I did some experiments a few weeks ago. I'll take a look how viable they are at the moment or if it makes more sense to fix the button states separately.