Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Re-export all the styles modules from core #17419

Merged
merged 4 commits into from
Oct 1, 2019

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Sep 13, 2019

  • I have followed (at least) the PR section of the contributing guide.

  • Re-export StylesProvider from @material-ui/styles/StylesProvider

  • Update @material-ui/styles to export everything from StylesProvider

@oliviertassinari Edit:

  • Re-export all the styles modules from core

Closes #17418

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 13, 2019

@material-ui/core: parsed: +0.32% , gzip: +0.31%

Details of bundle changes.

Comparing: f25c643...093d2cf

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.32% 🔺 +0.31% 🔺 332,485 333,558 90,719 91,000
@material-ui/core/Paper +0.17% 🔺 -0.08% 68,882 68,996 20,527 20,511
@material-ui/core/Paper.esm +0.01% 🔺 -0.01% 62,319 62,324 19,264 19,263
@material-ui/core/Popper 0.00% +0.07% 🔺 28,405 28,405 10,172 10,179
@material-ui/core/Textarea 0.00% -0.09% 5,082 5,082 2,136 2,134
@material-ui/core/TrapFocus 0.00% +0.06% 🔺 3,766 3,766 1,596 1,597
@material-ui/core/styles/createMuiTheme +0.02% 🔺 +0.05% 🔺 16,348 16,351 5,818 5,821
@material-ui/core/useMediaQuery 0.00% +0.19% 🔺 2,488 2,488 1,050 1,052
@material-ui/lab 0.00% +0.03% 🔺 143,352 143,353 43,792 43,804
@material-ui/styles +0.17% 🔺 -0.08% 51,641 51,727 15,353 15,340
@material-ui/system +0.01% 🔺 -0.05% 15,581 15,583 4,341 4,339
Button 0.00% +0.05% 🔺 78,719 78,720 24,031 24,043
Modal 0.00% 0.00% 14,542 14,542 5,113 5,113
Portal 0.00% -0.15% 2,907 2,907 1,318 1,316
Rating 0.00% +0.05% 🔺 70,185 70,186 21,915 21,926
Slider 0.00% +0.04% 🔺 75,326 75,327 23,248 23,258
colorManipulator 0.00% 0.00% 3,835 3,835 1,519 1,519
docs.landing 0.00% 0.00% 54,267 54,267 14,344 14,344
docs.main +0.02% 🔺 0.00% 587,126 587,261 187,881 187,885
packages/material-ui/build/umd/material-ui.production.min.js +0.40% 🔺 +0.45% 🔺 303,304 304,531 87,264 87,661

Generated by 🚫 dangerJS against 093d2cf

@oliviertassinari
Copy link
Member

This solves part of #17387 and #15867.

@oliviertassinari oliviertassinari changed the title [core] Re-export StylesProvider [core] Re-export all the styles modules from core Sep 29, 2019
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Sep 29, 2019
@oliviertassinari
Copy link
Member

@merceyz @mbrookes I have updated the pull request to handle the "export side" of #17387 (comment).
It should be a preliminary change to #17447. Are you happy with the changes?

There is one concern I'm not sure how we should handle: MuiThemeProvider vs ThemeProvider. So far the approach is to keep them scoped respectively to core and styles.

@oliviertassinari
Copy link
Member

@merceyz I'm sorry it took so long to come up with a solid path forward. I know it can be frustrating. We appreciate the care, thank you!

The next important topic we have left aside and that we need to move forward is the Babel plugin effort. I think that publishing our own Babel plugin is actually a good idea. It would allow us new doors. The first immediate advantage will be a configuration less support for option 2 of treeshaking.

Another effort that you started and that was very interesting is the migration of the props definitions to TypeScript.

@merceyz merceyz deleted the stylesprovider branch November 25, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
3 participants