-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Re-export all the styles modules from core #17419
Conversation
@material-ui/core: parsed: +0.32% , gzip: +0.31% Details of bundle changes.Comparing: f25c643...093d2cf
|
18d775a
to
093d2cf
Compare
@merceyz @mbrookes I have updated the pull request to handle the "export side" of #17387 (comment). There is one concern I'm not sure how we should handle: MuiThemeProvider vs ThemeProvider. So far the approach is to keep them scoped respectively to core and styles. |
@merceyz I'm sorry it took so long to come up with a solid path forward. I know it can be frustrating. We appreciate the care, thank you! The next important topic we have left aside and that we need to move forward is the Babel plugin effort. I think that publishing our own Babel plugin is actually a good idea. It would allow us new doors. The first immediate advantage will be a configuration less support for option 2 of treeshaking. Another effort that you started and that was very interesting is the migration of the props definitions to TypeScript. |
I have followed (at least) the PR section of the contributing guide.
Re-export StylesProvider from@material-ui/styles/StylesProvider
Update@material-ui/styles
to export everything fromStylesProvider
@oliviertassinari Edit:
Closes #17418