[Select] Simplify blur logic #17299
Merged
[Select] Simplify blur logic #17299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
Details of bundle changes.Comparing: 40fad15...9cd829b
|
eps1lon
commented
Sep 3, 2019
eps1lon
commented
Sep 3, 2019
eps1lon
commented
Sep 3, 2019
| onClick={disabled || readOnly ? null : handleClick} | ||
| /* prevent focusing the trigger since we'll open anyway and move focus */ | ||
| onMouseDown={e => e.preventDefault()} |
There was a problem hiding this comment.
Otherwise the trigger gets focused applying styles that are immediately removed because we focus an option in the listbox i.e. what the comment says 😄
There was a problem hiding this comment.
We want to display the select in active state since this is closer to the native select but does not follow WAI-ARIA.
eps1lon
force-pushed
the
fix/select/blur-controlled
branch
from
3be538d to
de48b3f
Compare
eps1lon
force-pushed
the
fix/select/blur-controlled
branch
from
de48b3f to
236a94b
Compare
eps1lon
commented
Oct 1, 2019
| expect(container.querySelector('[for="age-simple"]')).to.have.class('focused-label'); | ||
| }); | ||
|
|
||
| it('does not stays in an active state if an open action did not actually open', () => { |
There was a problem hiding this comment.
This actually breaks on master confirming what we see in #17294
oliviertassinari
approved these changes
Oct 1, 2019
That is outdated. I was originally following the WAI-ARIA practices but decided to keep the old implementation (which is closer to the native select). |
|
Well done! |
2 tasks
2 tasks
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17294
The previous implementation assumed that the open actions would actually open the select. The issue however illustrated a case where this assumption didn't hold which caused a broken looking UI (which could be restore by bluring manually).
The overall problem is that using InputBase is the wrong abstraction. We're abusing the focused state of the input to display the select as active. The trigger isn't focused anymore. So far nobody complained so I guess this is ok to keep. Just something we need to keep in mind.