Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ToggleButton] Update TypeScript class keys #17278

Merged
merged 3 commits into from
Sep 2, 2019
Merged

[ToggleButton] Update TypeScript class keys #17278

merged 3 commits into from
Sep 2, 2019

Conversation

ljvanschie
Copy link
Contributor

@ljvanschie ljvanschie commented Sep 2, 2019 •
edited
Loading

Some classes were added to ToggleButtonGroup recently (#17187); this PR updates the typescript class key definitions accordingly.

Also removed selected class key as it looks like it isn't used anymore.

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 2, 2019 •
edited
Loading

No bundle size changes comparing f55f3a4...875bf2b

Generated by 🚫 dangerJS against 875bf2b

@oliviertassinari oliviertassinari added component: toggle button This is the name of the generic UI component, not the React module! typescript labels Sep 2, 2019
@oliviertassinari oliviertassinari changed the title [ToggleButtonGroup] Update typescript class keys [ToggleButton] Update typescript class keys Sep 2, 2019
@oliviertassinari oliviertassinari changed the title [ToggleButton] Update typescript class keys [ToggleButton] Update TypeScript class keys Sep 2, 2019
@oliviertassinari oliviertassinari merged commit d81e0a7 into mui:master Sep 2, 2019
@oliviertassinari
Copy link
Member

Thanks, turns out, the ToggleButton definition was out of sync too.

@ljvanschie ljvanschie deleted the update-toggle-button-group-class-keys branch September 2, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: toggle button This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljvanschie @mui-pr-bot @oliviertassinari