Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Add missing fontStyle type to TypographyStyle #15733

Merged
merged 1 commit into from
May 17, 2019
Merged

[core] Add missing fontStyle type to TypographyStyle #15733

merged 1 commit into from
May 17, 2019

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented May 17, 2019

  • Add fontStyle to createTypography.d.ts
  • Add TypeScript version of the TypographyTheme demo
  • Switch to makeStyles

@eps1lon eps1lon added package: material-ui Specific to @mui/material typescript labels May 17, 2019
@mui-pr-bot
Copy link

No bundle size changes comparing 1291dca...bbf1df0

Generated by 🚫 dangerJS against bbf1df0

@eps1lon eps1lon merged commit ffffcb2 into mui:next May 17, 2019
@eps1lon
Copy link
Member

eps1lon commented May 17, 2019

@merceyz Much appreciated. Thanks.

@merceyz merceyz deleted the styles/createtypography-type-fix branch May 17, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@merceyz @mui-pr-bot @eps1lon @oliviertassinari