Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Persist the side nav scroll #15704

Merged
merged 8 commits into from
May 15, 2019
Merged

[docs] Persist the side nav scroll #15704

merged 8 commits into from
May 15, 2019

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 15, 2019 •
edited
Loading

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label May 15, 2019
@oliviertassinari oliviertassinari requested a review from mbrookes May 15, 2019 00:18
@mui-pr-bot
Copy link

mui-pr-bot commented May 15, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 3686a27...70bc4e1

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 317,580 317,580 86,695 86,695
@material-ui/core/Paper 0.00% 0.00% 67,869 67,869 20,171 20,171
@material-ui/core/Paper.esm 0.00% 0.00% 61,152 61,152 18,956 18,956
@material-ui/core/Popper 0.00% 0.00% 28,738 28,738 10,351 10,351
@material-ui/core/Textarea 0.00% 0.00% 5,513 5,513 2,384 2,384
@material-ui/core/TrapFocus 0.00% 0.00% 3,744 3,744 1,580 1,580
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,960 15,960 5,779 5,779
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 974 974
@material-ui/lab 0.00% 0.00% 140,516 140,516 42,852 42,852
@material-ui/styles 0.00% 0.00% 51,353 51,353 15,188 15,188
@material-ui/system 0.00% 0.00% 14,458 14,458 4,175 4,175
Button 0.00% 0.00% 85,781 85,781 25,769 25,769
Modal 0.00% 0.00% 20,342 20,342 6,699 6,699
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 47,836 47,836 10,920 10,920
docs.main -0.04% 0.00% 657,133 656,874 206,077 206,087
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 296,491 296,491 84,085 84,085

Generated by 🚫 dangerJS against 70bc4e1

@eps1lon eps1lon self-requested a review May 15, 2019 13:40
mbrookes
mbrookes approved these changes May 15, 2019
View reviewed changes
Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better UX. Thanks for fixing the S&R snafu.

@oliviertassinari oliviertassinari merged commit 752bf0e into mui:next May 15, 2019
@oliviertassinari oliviertassinari deleted the docs-small-fixes-v3 branch May 15, 2019 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@mbrookes mbrookes mbrookes approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliviertassinari @mui-pr-bot @mbrookes @eps1lon