Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove unused imports and declarations #15479

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Apr 24, 2019

@mui-pr-bot
Copy link

No bundle size changes comparing d1df9a8...0297e71

Generated by 🚫 dangerJS against 0297e71

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Apr 25, 2019
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, what methodology did you use to spot them?

@merceyz
Copy link
Member Author

merceyz commented Apr 25, 2019

what methodology did you use to spot them?

@oliviertassinari Saw a few of them when looking at the docs, enabled compile errors on unused variables to spot them and removed them manually.

@merceyz merceyz deleted the docs/unused-imports branch April 25, 2019 16:06
@oliviertassinari
Copy link
Member

@merceyz Would it be possible to move this compilation option to our tsconfig.json?

@eps1lon
Copy link
Member

eps1lon commented Apr 25, 2019

@merceyz Would it be possible to move this compilation option to our tsconfig.json?

In docs/tsconfig only preferably. We need unused variables for the other type tests.

@merceyz
Copy link
Member Author

merceyz commented Apr 25, 2019

Yes, however it is a nightmare to have on when developing as it gives you compile errors, so it should only be enabled in CI builds. TSLint has an option for it but it's deprecated.

I can add a check in #15438 that will report the error when transpiling, it would only work if the whole import statement was unused

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 25, 2019

I agree for the CI only change. Sebastian is right. We are only interested in the docs folder.

@merceyz
Copy link
Member Author

merceyz commented Apr 26, 2019

I'll hopefully have a PR ready tomorrow

@merceyz
Copy link
Member Author

merceyz commented Apr 26, 2019

@oliviertassinari @eps1lon PR ready, #15501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants