-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Remove unused imports and declarations #15479
Conversation
merceyz
commented
Apr 24, 2019
- I have followed (at least) the PR section of the contributing guide.
No bundle size changes comparing d1df9a8...0297e71 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, what methodology did you use to spot them?
@oliviertassinari Saw a few of them when looking at the docs, enabled compile errors on unused variables to spot them and removed them manually. |
@merceyz Would it be possible to move this compilation option to our |
In docs/tsconfig only preferably. We need unused variables for the other type tests. |
Yes, however it is a nightmare to have on when developing as it gives you compile errors, so it should only be enabled in CI builds. TSLint has an option for it but it's deprecated.
|
I agree for the CI only change. Sebastian is right. We are only interested in the docs folder. |
I'll hopefully have a PR ready tomorrow |
@oliviertassinari @eps1lon PR ready, #15501 |