Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix useLayoutEffect warnings on the server #15463

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 23, 2019

I don't think we should abstract this logic. I would hope that this will get addressed by React.

See facebook/react#14927

@eps1lon eps1lon added bug 🐛 Something doesn't work component: MenuList labels Apr 23, 2019
@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: 387b79e...595779a

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.03% 🔺 +0.04% 🔺 311,042 311,136 84,214 84,244
@material-ui/core/Paper 0.00% 0.00% 67,279 67,279 19,970 19,970
@material-ui/core/Paper.esm 0.00% 0.00% 60,640 60,640 18,897 18,897
@material-ui/core/Popper 0.00% 0.00% 31,115 31,115 10,793 10,793
@material-ui/core/Textarea 0.00% 0.00% 5,472 5,472 2,367 2,367
@material-ui/core/TrapFocus 0.00% 0.00% 3,731 3,731 1,565 1,565
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,898 15,898 5,770 5,770
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 973 973
@material-ui/lab 0.00% 0.00% 140,720 140,720 42,642 42,642
@material-ui/styles 0.00% 0.00% 50,833 50,833 15,019 15,019
@material-ui/system 0.00% 0.00% 11,765 11,765 3,922 3,922
Button 0.00% 0.00% 85,622 85,622 25,618 25,618
Modal 0.00% 0.00% 79,337 79,337 23,972 23,972
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 51,154 51,154 11,250 11,250
docs.main +0.02% 🔺 0.00% 648,059 648,161 202,187 202,195
packages/material-ui/build/umd/material-ui.production.min.js +0.03% 🔺 +0.03% 🔺 292,088 292,178 82,119 82,144

Generated by 🚫 dangerJS against 595779a

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have missed it. Well spotted.

@eps1lon eps1lon merged commit f0dd1d5 into mui:next Apr 23, 2019
@eps1lon eps1lon deleted the fix/ssr-layout-warnings branch April 23, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants