[test] Conform components forward ref to root component #15425
Conversation
|
No bundle size changes comparing bdaadb5...cc4e636 |
|
|
||
| if (inheritComponent && instance instanceof window.Element) { | ||
| const rootHost = findOutermostIntrinsic(wrapper); | ||
| assert.strictEqual(instance, rootHost.instance()); |
There was a problem hiding this comment.
I'm not sure to fully understand the implication. Does it prevent the Switch.js pattern to pass the ref test? (that has a wrapping div element)
There was a problem hiding this comment.
Switch is not a conform component (according to the definition you preferred) as far as I know.
There was a problem hiding this comment.
Sure, but what are we going to do with the Switch component? I "think" (slightly leaning) that we should break it for the InputBase component. It's probably more intuitive to farward the props to the input element. 80% of the time, users can ignore the wrapping div 🤔. The inputProps has created a lot of confusion. How can we do better?
There was a problem hiding this comment.
Sure, but what are we going to do with the Switch component?
Why is this question important here?
There was a problem hiding this comment.
I was wondering out of my lack of knowledge of the describeConformance.js logic.
We move from a test that only checks that the ref is forwarded somewhere to a test that checks where the ref is forwarded. Now, I realize we do the same with the other tests, so 👍.
There was a problem hiding this comment.
Exactly. Should've compiled the relevant conversations into a proper PR description.
Cherry-pick improved ref testing from #15387