Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popper] Convert to function component #15405

Merged
merged 3 commits into from
Apr 21, 2019
Merged

[Popper] Convert to function component #15405

merged 3 commits into from
Apr 21, 2019

Conversation

joshwooding
Copy link
Member

@joshwooding joshwooding commented Apr 18, 2019 •
edited
Loading

Works towards #15231

@joshwooding joshwooding added new feature New feature or request component: Popper The React component. See <Popup> for the latest version. labels Apr 18, 2019
@joshwooding joshwooding mentioned this pull request Apr 18, 2019
Closed
29 tasks
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 18, 2019 •
edited
Loading

@material-ui/core: parsed: -0.29% 😍, gzip: -0.23% 😍
@material-ui/lab: parsed: -0.65% 😍, gzip: -0.39% 😍

Details of bundle changes.

Comparing: a494652...7df751c

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.29% -0.23% 312,618 311,699 84,447 84,255
@material-ui/core/Paper -0.00% -0.03% 67,279 67,278 19,968 19,963
@material-ui/core/Paper.esm -0.00% +0.02% 🔺 60,640 60,639 18,884 18,888
@material-ui/core/Popper -10.87% -8.58% 34,907 31,114 11,812 10,798
@material-ui/core/Textarea 0.00% -0.22% 5,327 5,327 2,291 2,286
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,898 15,898 5,771 5,771
@material-ui/core/useMediaQuery 0.00% -0.31% 2,106 2,106 974 971
@material-ui/lab -0.65% -0.39% 141,612 140,694 42,722 42,554
@material-ui/styles -0.00% -0.03% 50,833 50,831 15,013 15,009
@material-ui/system 0.00% -0.03% 11,765 11,765 3,928 3,927
Button -0.00% +0.09% 🔺 85,621 85,620 25,588 25,612
Modal 0.00% +0.02% 🔺 79,901 79,901 24,011 24,017
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 50,908 50,908 11,210 11,210
docs.main -0.14% -0.12% 648,518 647,622 201,926 201,691
packages/material-ui/build/umd/material-ui.production.min.js -0.29% -0.26% 293,911 293,070 82,492 82,281

Generated by 🚫 dangerJS against 7df751c

@joshwooding joshwooding force-pushed the popper-convert-to-function-component branch from 42c7233 to 912e804 Compare April 18, 2019 19:43
@oliviertassinari oliviertassinari merged commit 947853d into mui:next Apr 21, 2019
@joshwooding joshwooding deleted the popper-convert-to-function-component branch April 21, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: Popper The React component. See <Popup> for the latest version. new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshwooding @mui-pr-bot @oliviertassinari @eps1lon