Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Reduce calls to actions prop #15370

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 16, 2019

imperative handles were created on every render without any need. We can use deps and eslint to safely reduce those to a bare minimum.

imperative handles were created on every render without any need.
We can use deps and eslint to safely reduce those to a bare
minimum
@eps1lon eps1lon added performance package: material-ui Specific to @mui/material labels Apr 16, 2019
@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: 1d6425d...397ccee

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 346,659 346,665 89,735 89,737
@material-ui/core/Paper 0.00% 0.00% 68,404 68,404 20,053 20,053
@material-ui/core/Paper.esm 0.00% 0.00% 60,735 60,735 18,785 18,785
@material-ui/core/Popper 0.00% 0.00% 34,930 34,930 11,917 11,917
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 17,877 17,877 5,962 5,962
@material-ui/core/useMediaQuery 0.00% 0.00% 2,463 2,463 1,044 1,044
@material-ui/lab 0.00% 0.00% 148,083 148,083 43,911 43,911
@material-ui/styles 0.00% 0.00% 53,143 53,143 15,443 15,443
@material-ui/system 0.00% 0.00% 17,132 17,132 4,519 4,519
Button 0.00% 0.00% 88,669 88,669 26,423 26,423
Modal 0.00% 0.00% 82,688 82,688 24,802 24,802
colorManipulator 0.00% 0.00% 3,745 3,745 1,537 1,537
docs.landing 0.00% 0.00% 50,908 50,908 11,210 11,210
docs.main 0.00% 0.00% 650,087 650,090 202,396 202,396
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 295,447 295,453 82,693 82,694

Generated by 🚫 dangerJS against 397ccee

@eps1lon eps1lon merged commit 2193658 into mui:next Apr 16, 2019
@eps1lon eps1lon deleted the fix/core/reduce-imperative-handle-calls branch April 16, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: material-ui Specific to @mui/material performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants