Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popover] Add warning when non-ref-holding component is used in Paper #15181

Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 3, 2019

Adds an additional warning to <Popover open PaperProps={{ component: () => <div />, elevation: 4 }} />. This would already trigger a warning in React. We improve the error message with elementTypeAcceptingRef

@eps1lon eps1lon added docs Improvements or additions to the documentation component: Popover The React component. labels Apr 3, 2019
@eps1lon eps1lon force-pushed the feat/Popover/improve-ref-warnings branch from f7d4cc3 to a59eec8 Compare April 3, 2019 16:14
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 3, 2019

Details of bundle changes.

Comparing: ae24eea...ad091d6

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.00% -0.00% 349,543 349,529 89,881 89,878
@material-ui/core/Paper 0.00% 0.00% 67,853 67,853 19,809 19,809
@material-ui/core/Paper.esm 0.00% 0.00% 60,184 60,184 18,558 18,558
@material-ui/core/Popper 0.00% 0.00% 34,825 34,825 11,883 11,883
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 17,364 17,364 5,726 5,726
@material-ui/core/useMediaQuery 0.00% 0.00% 2,469 2,469 1,042 1,042
@material-ui/lab 0.00% 0.00% 147,331 147,331 43,555 43,555
@material-ui/styles 0.00% 0.00% 53,105 53,105 15,424 15,424
@material-ui/system 0.00% 0.00% 17,136 17,136 4,525 4,525
Button 0.00% 0.00% 87,919 87,919 26,055 26,055
Modal 0.00% 0.00% 82,035 82,035 24,553 24,553
colorManipulator 0.00% 0.00% 3,232 3,232 1,301 1,301
docs.landing 0.00% 0.00% 49,914 49,914 10,815 10,815
docs.main -0.00% 0.00% 645,251 645,249 200,422 200,424
packages/material-ui/build/umd/material-ui.production.min.js -0.00% -0.00% 297,961 297,947 82,664 82,662

Generated by 🚫 dangerJS against ad091d6

@oliviertassinari
Copy link
Member

Smart.

@oliviertassinari oliviertassinari merged commit 10d0628 into mui:next Apr 4, 2019
@eps1lon eps1lon deleted the feat/Popover/improve-ref-warnings branch May 18, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Popover The React component. docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants