Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextField] Add links to Input and Select #15148

Merged
merged 6 commits into from
Apr 4, 2019
Merged

[TextField] Add links to Input and Select #15148

merged 6 commits into from
Apr 4, 2019

Conversation

MrHen
Copy link
Contributor

@MrHen MrHen commented Apr 1, 2019

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 1, 2019 •
edited
Loading

No bundle size changes comparing 81e82b0...220e76b

Generated by 🚫 dangerJS against 220e76b

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: text field This is the name of the generic UI component, not the React module! labels Apr 1, 2019
@oliviertassinari oliviertassinari self-assigned this Apr 2, 2019
@oliviertassinari oliviertassinari removed their assignment Apr 2, 2019
mbrookes
mbrookes previously requested changes Apr 3, 2019
View reviewed changes
Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few (mostly repetitive) suggestions.

packages/material-ui/src/InputBase/InputBase.js Outdated Show resolved Hide resolved
packages/material-ui/src/OutlinedInput/OutlinedInput.js Outdated Show resolved Hide resolved
packages/material-ui/src/Radio/Radio.js Outdated Show resolved Hide resolved
packages/material-ui/src/Switch/Switch.js Outdated Show resolved Hide resolved
packages/material-ui/src/TextField/TextField.js Outdated Show resolved Hide resolved
packages/material-ui/src/TextField/TextField.js Outdated Show resolved Hide resolved
packages/material-ui/src/internal/SwitchBase.js Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari merged commit cc0ac06 into mui:next Apr 4, 2019
@oliviertassinari
Copy link
Member

@mbrookes Thank, I have updated the wording and added new links. I often people that don't realize that they can use the native input element attributes. The links will help 👌 .

@oliviertassinari
Copy link
Member

@MrHen It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@MrHen MrHen deleted the patch-1 branch April 4, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mbrookes mbrookes mbrookes left review comments

Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrHen @mui-pr-bot @oliviertassinari @mbrookes