-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dialog] Add dialog with close button to demos #13845
[Dialog] Add dialog with close button to demos #13845
Conversation
@rfbotto I have pushed the approach one step further. Let me know what you think :) |
fc10430
to
f56362f
Compare
I don't think we should add demos the go against material guidelines. It might be especially confusing since close icons for fullscreen dialogs are located on the left while this one is on the right. |
@eps1lon What would you change? |
Well google engineers are also extending their designers decisions. This settles it for me then WRT to close icon. I guess the important part here is that there would be no close action without the icon. The demo should reflect that. So replace the cancel action with something else so that the close action is not ambiguous. |
@oliviertassinari Prefer it much more the way you did. Much cleaner and readable👍 Plus, i like the change to the demos buttons, makes them much more prominent. When it comes to the google material guidelines, as long as we make clear that we are getting away from the specification by allowing the customisation of the default behaviour, it should be okay, no? |
f56362f
to
802170a
Compare
802170a
to
f1ebc9b
Compare
@eps1lon Points taken. I have removed the close button in the footer (one way to do it) add I have added warnings about the non-material demos (to remove the ambiguity) following your feedback. |
Closes #13520