Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LinearProgress] Add determinate and indeterminate classes to root element #13828

Merged
merged 2 commits into from
Dec 6, 2018
Merged

[LinearProgress] Add determinate and indeterminate classes to root element #13828

merged 2 commits into from
Dec 6, 2018

Conversation

alexsanchezdev
Copy link
Contributor

@alexsanchezdev alexsanchezdev commented Dec 5, 2018 •
edited
Loading

Fixes #13713

Solution

  • Add indeterminate class to the root element
  • Add determinate class to the root element

@alexsanchezdev alexsanchezdev changed the title [LinearProgress] Add determinate and indeterminate classes to root element [LinearProgress] #13713 Add determinate and indeterminate classes to root element Dec 6, 2018
@alexsanchezdev alexsanchezdev changed the title [LinearProgress] #13713 Add determinate and indeterminate classes to root element [LinearProgress] Add determinate and indeterminate classes to root element Dec 6, 2018
@alexsanchezdev alexsanchezdev mentioned this pull request Dec 6, 2018
Closed
2 tasks
@oliviertassinari oliviertassinari added new feature New feature or request component: LinearProgress The React component. labels Dec 6, 2018
@oliviertassinari oliviertassinari merged commit 2f77ff5 into mui:master Dec 6, 2018
@oliviertassinari
Copy link
Member

@alxsnchez It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@alexsanchezdev
Copy link
Contributor Author

@oliviertassinari and not last, this library helped me a lot and will try to give it back to help others! So expect more from me... :)

@oliviertassinari
Copy link
Member

@alxsnchez There is a lot to be done, your help is welcomed :)

@oliviertassinari oliviertassinari added the component: progress This is the name of the generic UI component, not the React module! label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: LinearProgress The React component. component: progress This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LinearProgress] Add more classes keys
2 participants
@alexsanchezdev @oliviertassinari