[Input] Make CSS override a bit simpler #13825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's hard to change the color of Input underline because it's a complex selector to override. If this selector only change `borderBottomWidth` and `borderBottomStyle` separately, we will just need to change the `&:before`
oliviertassinari
added
new feature
|
I wish it was that simple, but it's not. We change the color. |
oliviertassinari
approved these changes
Dec 5, 2018
oliviertassinari
changed the title
|
@euharrison The disabled dotted style is good to take :) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard to change the color of Input underline because it's a complex selector to override.
If this selector only change
borderBottomWidthandborderBottomStyleseparately, we will just need to change the&:beforeFrom
To