[styles] Infer optional props argument for makeStyles in TypeScript #13815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
typescript
package: styles
1 task
eps1lon
force-pushed
the
fix/styles/makeStyles/optional-props
branch
from
ca668d5 to
7a9a332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #13801.
Enables omission of the props argument in the returned hook function if no props are referenced in the styles argument for
makeStyles.Whenever the typechecker infers that the type of the props is
anywe make the argument optional. If people would explicitly annotate the props used inmakeStylesthen they could've already passedundefined.