[Popper] Save 7 KB gzipped (for people only using it) #13804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
oliviertassinari
force-pushed
the
react-popper-docs
branch
from
bbb7510 to
f4dbbdc
Compare
oliviertassinari
commented
Dec 4, 2018
.size-limit.js
Outdated
| name: 'The size of the @material-ui/core/Popper component', | ||
| webpack: true, | ||
| path: 'packages/material-ui/build/Popper/index.js', | ||
| limit: '16.0 KB', |
There was a problem hiding this comment.
The withTheme import for RTL support costs us 7 kB gzipped. Maybe we should look in the body dir attribute instead? cc @eps1lon?
oliviertassinari
force-pushed
the
react-popper-docs
branch
from
f4dbbdc to
860a44e
Compare
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
react-popper-docs
branch
from
860a44e to
8d31485
Compare
oliviertassinari
commented
Dec 4, 2018
| name: 'The size of the @material-ui/core/Popper component', | ||
| webpack: true, | ||
| path: 'packages/material-ui/build/Popper/index.js', | ||
| limit: '10.0 KB', |
There was a problem hiding this comment.
popper.js alone costs 7 kB: https://bundlephobia.com/result?p=popper.js.
joshwooding
reviewed
Dec 4, 2018
oliviertassinari
force-pushed
the
react-popper-docs
branch
from
8d31485 to
af2111d
Compare
eps1lon
reviewed
Dec 5, 2018
There was a problem hiding this comment.
Some issues:
- does not detect direction changes
- reads from the DOM during render phase
- [core] Improve tree-shakeability #13391 is a candidate for reduced bundle size for Popper only usage since it will remove
withStylesfrom the bundle
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.