Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add a new onepirate theme #13769

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Dec 2, 2018

A simple example theme. Not the prettiest one.

Preview: https://deploy-preview-13769--material-ui.netlify.com/premium-themes/onepirate/

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Dec 2, 2018
@oliviertassinari oliviertassinari force-pushed the theme-add-onepirate branch 4 times, most recently from d3b3f0f to 1843e67 Compare December 2, 2018 20:52
@oliviertassinari oliviertassinari self-assigned this Dec 2, 2018
@oliviertassinari oliviertassinari merged commit dc4d1eb into mui:master Dec 3, 2018
@oliviertassinari oliviertassinari deleted the theme-add-onepirate branch December 3, 2018 09:16
@dnafication
Copy link

Is this using material-ui library? If not why do we have it under free themes section of material-ui?

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Dec 10, 2018

Yes, it's using Material-UI with some overrides. So is https://siriwatknp.github.io/material-ui-theme-generator/?knob-open=true&selectedKind=Pages%7CFirebase&selectedStory=Authen&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybooks%2Fstorybook-addon-knobs.

@mbrookes
Copy link
Member

@dnafication Don't think of Material-UI purely in terms om Material Design. Any component library consists of two parts - its function, and its appearance.

Material-UI is specifically designed to allow its appearance to be customized, while benefiting from the well tested functionality. The fact that it wasn't clear that OnePirate builds on Material-UI is testament to the flexibility of Material-UI as a core platform for your own design.

@dnafication
Copy link

dnafication commented Dec 10, 2018

Wow, so many derivatives based on what I thought was mainly for the Material Design guidelines. That's good to know. 😊

@kpennell
Copy link

kpennell commented Mar 2, 2019

@oliviertassinari I'm trying to clone this example but when I git clone, many of the files are missing.

@oliviertassinari
Copy link
Member Author

@kpennell Can we continue the conversation in #14604?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants