Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ToggleButtonGroup] Consider nullish instead of falsy value as no selected value #13494

Merged
merged 1 commit into from
Dec 2, 2018
Merged

[ToggleButtonGroup] Consider nullish instead of falsy value as no selected value #13494

merged 1 commit into from
Dec 2, 2018

Conversation

ItamarShDev
Copy link
Contributor

@ItamarShDev ItamarShDev commented Nov 2, 2018 •
edited by oliviertassinari
Loading

Closes #13488

@oliviertassinari oliviertassinari added the component: toggle button This is the name of the generic UI component, not the React module! label Nov 2, 2018
@ItamarShDev ItamarShDev changed the title hasValue - Fix false falsy value check [hasValue] Fix false falsy value check Nov 3, 2018
@eps1lon
Copy link
Member

eps1lon commented Nov 3, 2018

I also don't think we need another demo for this. The unit test and documentation that ToggleButton should have a value other than null or undefined is sufficient in my opinion. Or include an emtpy string in the other demos.

@joshwooding
Copy link
Member

@ItamarShDev Are you still working on this?

@ItamarShDev
Copy link
Contributor Author

@joshwooding Yes
I was off for a bit, due do my wife's pregnancy.

@ItamarShDev ItamarShDev changed the title [hasValue] Fix false falsy value check [hasValue] Fix false falsey value check Dec 1, 2018
@ItamarShDev
Copy link
Contributor Author

@eps1lon resolved the comments
Thank you

@joshwooding
Copy link
Member

joshwooding commented Dec 1, 2018 •
edited
Loading

@joshwooding Yes
I was off for a bit, due do my wife's pregnancy.

@ItamarShDev No worries :), Congratulations 🎊

@eps1lon
Copy link
Member

eps1lon commented Dec 1, 2018

Is this rebased with the latest master? Can't explain some reports in the visual regression tests otherwise.

@ItamarShDev
Copy link
Contributor Author

@eps1lon its based on master as of 28 days ago. will rebase

@ItamarShDev
Copy link
Contributor Author

@eps1lon rebased and removed the UI example

@eps1lon eps1lon changed the title [hasValue] Fix false falsey value check [ToggleButtonGroup] Consider nullish instead of falsy value as no selected value Dec 2, 2018
@eps1lon eps1lon merged commit 8155d46 into mui:master Dec 2, 2018
@eps1lon
Copy link
Member

eps1lon commented Dec 2, 2018

@ItamarShDev Thanks for working on this and well done!

@ItamarShDev ItamarShDev deleted the fix-falsy-in-hasValue branch December 2, 2018 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon left review comments

Assignees
No one assigned
Labels
component: toggle button This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ItamarShDev @eps1lon @joshwooding @oliviertassinari