[core] Only use debounce client-side #13255
Conversation
oliviertassinari
force-pushed
the
debounce-client-side
branch
5 times, most recently
from
f919d3d to
6c27ae6
Compare
oliviertassinari
force-pushed
the
debounce-client-side
branch
from
6c27ae6 to
605fb9c
Compare
| defaultTheme = createMuiTheme(); | ||
| defaultTheme = createMuiTheme({ | ||
| typography: { | ||
| suppressWarning: true, |
There was a problem hiding this comment.
@oliviertassinari
I just found this. Why was this snuck in in this PR? We had this discussion over and over. If you don't care about deprecation warnings just say it and we can leave this discussion behind. I'm tired of watching every commit so that you don't work against the determined deprecation behavior in the RFC.
There was a problem hiding this comment.
The motivation is the same of the fix proposed in #13657. Let me know what you think about it. Basically, a user not providing it's custom theme shouldn't see a warning. He is doing nothing wrong?
There was a problem hiding this comment.
Why was it introduced in this pull request? Hum, probably because I want to minimize the numbers of commits I'm doing, I try to batch them so our contribution graph looks more balanced. Or maybe because I have realized the issue doing this effort and it was simpler to do it all at once. I should have asked first.
There was a problem hiding this comment.
Oh yes, that was it. I was probably running the benchmark test suite, without providing a custom them then I saw this warning pop. I think that its important people can use Material-UI without having to provide a theme.
There was a problem hiding this comment.
Do you want to change the tradeoff?
Win ~5% of server-side rendering performance per debounce deferred to the client. For instance, around 10% for the tab that uses two debounce.