Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add closing tag in the Popover snippet #13026

Merged
merged 2 commits into from
Sep 28, 2018
Merged

[docs] Add closing tag in the Popover snippet #13026

merged 2 commits into from
Sep 28, 2018

Conversation

liesislukas
Copy link
Contributor

@liesislukas liesislukas commented Sep 28, 2018 •
edited by oliviertassinari
Loading

the copied code doesn't work because missing the closing tag.

Closes #13025

@liesislukas
adding closing tag #13025
3f9810c 
the copied code doesn't work because missing the closing tag.
@liesislukas
better closing tag with sample content
d3476f9
@oliviertassinari oliviertassinari changed the title adding closing tag #13025 [docs] Add closing tag in the Popover snippet Sep 28, 2018
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Sep 28, 2018
@oliviertassinari oliviertassinari merged commit f1b4195 into mui:master Sep 28, 2018
@oliviertassinari
Copy link
Member

@liesislukas Nice!

marcelpanse pushed a commit to marcelpanse/material-ui that referenced this pull request Oct 2, 2018
@liesislukas @marcelpanse
[docs] Add closing tag in the Popover snippet (mui#13026)
6703d78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liesislukas @oliviertassinari