Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chip] Add an icon property #12881

Merged
merged 9 commits into from
Sep 16, 2018
Merged

[Chip] Add an icon property #12881

merged 9 commits into from
Sep 16, 2018

Conversation

aretheregods
Copy link
Contributor

@aretheregods aretheregods commented Sep 16, 2018

Closes #12789

@oliviertassinari oliviertassinari self-assigned this Sep 16, 2018
@oliviertassinari oliviertassinari changed the title [Chip] new icon attr [Chip] Add a icon property Sep 16, 2018
@oliviertassinari oliviertassinari added new feature New feature or request component: chip This is the name of the generic UI component, not the React module! labels Sep 16, 2018
@oliviertassinari oliviertassinari merged commit 814b7fa into mui:master Sep 16, 2018
@oliviertassinari oliviertassinari changed the title [Chip] Add a icon property [Chip] Add an icon property Sep 16, 2018
@oliviertassinari
Copy link
Member

@aretheregods It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

marcelpanse pushed a commit to marcelpanse/material-ui that referenced this pull request Oct 2, 2018
* Added icon attr with proper styling

* Added examples with icon attr utilized

* Added icon attr to form

* Added icon attr with proper styling

* Added examples with icon attr utilized

* Added icon attr to form

* Added icon info

* let's merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: chip This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants