-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Typography] Add inherit and screen reader only #12837
[Typography] Add inherit and screen reader only #12837
Conversation
857ba89
to
5c02039
Compare
|
@mbrookes I haven't tried with a screen reader, it might not work. I can only find reference to stuff like http://web-accessibility.carnegiemuseums.org/code/svg/. |
I should have checked the literature rather than just assuming, however: "SVG user agents MUST provide an accessible object in the accessibility tree for rendered SVG elements that meet any of the following criteria [...]:
https://www.w3.org/TR/svg-aam-1.0/#include_elements (which doesn't mean |
It's for Font icons right, not SVG? What do you prefer between |
🤦♂️
|
@@ -6,7 +6,7 @@ export function isBody(node) { | |||
return node && node.tagName.toLowerCase() === 'body'; | |||
} | |||
|
|||
// Do we have a scroll bar? | |||
// Do we have a veritcal scroll bar? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in vertical
@@ -32,6 +32,13 @@ export const styles = theme => ({ | |||
caption: theme.typography.caption, | |||
/* Styles applied to the root element if `variant="button"`. */ | |||
button: theme.typography.button, | |||
/* Styles applied to the root element if `variant="srOnly"`. Only targets the screen readers. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Only accessible to screen readers" would be better
I agree, however. The CSS API can help with the purpose of this class name. Bootstrap & Font Awesome are using the |
* [Typography] Add inherit and screen reader only * review
variant="srOnly"
use case:variant="inherit"
use case: