[SvgIcon] Add Icon suffix to SVG icons #12634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
added
new feature
oliviertassinari
added
component: SvgIcon
oliviertassinari
changed the title
|
@yordis It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot! |
marcelpanse
pushed a commit
to marcelpanse/material-ui
that referenced
this pull request
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this suffix helps the DevTools Tree view to identify the icon.
The issue I had was that I had two
Fullscreencomponents and when I used the search there was no way to know which one was which one.But adding this suffix helps to debug and have a cleaner Tree structure in the DevTools.