[Dialog] Add 'lg' support to maxWidth #12626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMoonDawg
commented
Aug 22, 2018
| @@ -21,7 +21,7 @@ Dialogs are overlaid modal paper based components with a backdrop. | |||
| | <span class="prop-name">disableEscapeKeyDown</span> | <span class="prop-type">bool | <span class="prop-default">false</span> | If `true`, hitting escape will not fire the `onClose` callback. | | |||
| | <span class="prop-name">fullScreen</span> | <span class="prop-type">bool | <span class="prop-default">false</span> | If `true`, the dialog will be full-screen | | |||
| | <span class="prop-name">fullWidth</span> | <span class="prop-type">bool | <span class="prop-default">false</span> | If `true`, the dialog stretches to `maxWidth`. | | |||
| | <span class="prop-name">maxWidth</span> | <span class="prop-type">enum: 'xs' |<br> 'sm' |<br> 'md' |<br> false<br> | <span class="prop-default">'sm'</span> | Determine the max width of the dialog. The dialog width grows with the size of the screen, this property is useful on the desktop where you might need some coherent different width size across your application. Set to `false` to disable `maxWidth`. | | |||
| | <span class="prop-name">maxWidth</span> | <span class="prop-type">enum: 'xs', 'sm', 'md', 'lg', false<br> | <span class="prop-default">'sm'</span> | Determine the max width of the dialog. The dialog width grows with the size of the screen, this property is useful on the desktop where you might need some coherent different width size across your application. Set to `false` to disable `maxWidth`. | | |||
There was a problem hiding this comment.
I generated this by running yarn docs:api as specified in the contributing guidelines. I noticed that the format changed slightly after running it, so I'm not sure what's up there.
1 task
oliviertassinari
added
new feature
Is it #10742? Thanks! |
|
Well, this time I actually wrote code instead of fixing an error message. 😉 Thanks for merging it! |
marcelpanse
pushed a commit
to marcelpanse/material-ui
that referenced
this pull request
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 'lg' as an option for maxWidth on Dialogs.
This is my first code PR, so please let me know if I missed anything!