Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Fix calculating tab indicator position #11825

Merged
merged 2 commits into from
Jun 12, 2018
Merged

[Tabs] Fix calculating tab indicator position #11825

merged 2 commits into from
Jun 12, 2018

Conversation

ljani
Copy link
Contributor

@ljani ljani commented Jun 12, 2018 •
edited
Loading

See disussion at the end of #8379.

Two questions:

  1. Is it okay to test internals (ie. valueToIndex)?
  2. Should I squash my failing test?

@oliviertassinari oliviertassinari added component: tabs This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Jun 12, 2018
@oliviertassinari oliviertassinari merged commit 258ceeb into mui:master Jun 12, 2018
@oliviertassinari
Copy link
Member

@ljani It's perfect 👌

@ljani ljani deleted the tabs-valuetoindex-fix branch June 12, 2018 13:48
acroyear pushed a commit to acroyear/material-ui that referenced this pull request Jul 14, 2018
@ljani
[Tabs] Fix calculating tab indicator position (mui#11825)
621e631 
* [Tabs] Add failing test for mui#8379

* [Tabs] Fix calculating tab indicator position

Fixes mui#8379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljani @oliviertassinari