Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Require node >=8.0.0 to work on the project #11407

Merged
merged 2 commits into from
May 15, 2018
Merged

[core] Require node >=8.0.0 to work on the project #11407

merged 2 commits into from
May 15, 2018

Conversation

sant0shg
Copy link

@sant0shg sant0shg commented May 15, 2018 •
edited by oliviertassinari
Loading

Closes #11405

@oliviertassinari oliviertassinari changed the title Updated node version to 10x [core] Require node >=9.0.0 to work on the project May 15, 2018
@oliviertassinari oliviertassinari merged commit d837dba into mui:v1-beta May 15, 2018
oliviertassinari pushed a commit that referenced this pull request May 15, 2018
@oliviertassinari
[core] Require node >=9.0.0 to work on the project (#11407)
ae35417 
* Updated node version to 10x

* Update package.json
@sant0shg
Copy link
Author

Thankyou @oliviertassinari

@oliviertassinari
Copy link
Member

@netdeamon It's a great first pull request on Material-UI 👌🏻.

@oliviertassinari oliviertassinari changed the title [core] Require node >=9.0.0 to work on the project [core] Require node >=8.0.0 to work on the project May 15, 2018
@cherniavskii
Copy link
Member

@oliviertassinari Why >=9.0.0? Current LTS is 8.x.x

@cherniavskii
Copy link
Member

@oliviertassinari ok, nevermind - just realized that it's set to ">=8.0.0" in package.json

@oliviertassinari
Copy link
Member

@cherniavskii Yes, I have rollback. This is only for the dev env. In production, we still support Node >= 6.0.0.

Bnaya
Bnaya reviewed May 17, 2018
View reviewed changes
package.json
@@ -165,7 +165,7 @@
"instrument": false
},
"engines": {
"node": ">=6.0.0"
"node": ">=9.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is 9 not 8 ><

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point? I have rollback in another commit.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. soz

@zannager zannager added the core Infrastructure work going on behind the scenes label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bnaya Bnaya Bnaya left review comments

@oliviertassinari oliviertassinari oliviertassinari left review comments

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sant0shg @oliviertassinari @cherniavskii @Bnaya @zannager