[core] Bundle UMD with rollup #11360
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "build/umd/material-ui.development.js": { | ||
| "bundled": 1060251, | ||
| "minified": 387201, | ||
| "gzipped": 98971 | ||
| }, | ||
| "build/umd/material-ui.production.min.js": { | ||
| "bundled": 891133, | ||
| "minified": 346152, | ||
| "gzipped": 89531 | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import nodeResolve from 'rollup-plugin-node-resolve'; | ||
| import commonjs from 'rollup-plugin-commonjs'; | ||
| import babel from 'rollup-plugin-babel'; | ||
| import replace from 'rollup-plugin-replace'; | ||
| import uglify from 'rollup-plugin-uglify'; | ||
| import { sizeSnapshot } from 'rollup-plugin-size-snapshot'; | ||
|
|
||
| const input = './src/index.js'; | ||
|
|
||
| const name = 'material-ui'; | ||
|
|
||
| const globals = { | ||
| react: 'React', | ||
| 'react-dom': 'ReactDOM', | ||
| }; | ||
|
|
||
| const getBabelOptions = () => ({ | ||
|
There was a problem hiding this comment. Something is off. Some babel plugins declared in .babelrc aren't applied. For instance, we still have the There was a problem hiding this comment. Yeah, current babelrc is a mess to be honest. It's better to specify targets in browserlist file and completely separate environments with only NODE_ENV. There was a problem hiding this comment. It seems There was a problem hiding this comment. Its done by rollup plugin replace. There was a problem hiding this comment. That's why sizes of bundles are different |
||
| exclude: /node_modules/, | ||
| // We are using @babel/plugin-transform-runtime | ||
| runtimeHelpers: true, | ||
| }); | ||
|
|
||
| const getCommonjsOptions = () => ({ | ||
| include: /node_modules/, | ||
| }); | ||
|
|
||
| export default [ | ||
| { | ||
| input, | ||
| output: { file: `build/umd/${name}.development.js`, format: 'umd', name, globals }, | ||
| external: Object.keys(globals), | ||
| plugins: [ | ||
| nodeResolve(), | ||
| babel(getBabelOptions()), | ||
| commonjs(getCommonjsOptions()), | ||
| sizeSnapshot(), | ||
| replace({ 'process.env.NODE_ENV': JSON.stringify('development') }), | ||
| ], | ||
| }, | ||
|
|
||
| { | ||
| input, | ||
| output: { file: `build/umd/${name}.production.min.js`, format: 'umd', name, globals }, | ||
| external: Object.keys(globals), | ||
| plugins: [ | ||
| nodeResolve(), | ||
| babel(getBabelOptions()), | ||
| commonjs(getCommonjsOptions()), | ||
| replace({ 'process.env.NODE_ENV': JSON.stringify('production') }), | ||
| sizeSnapshot(), | ||
| uglify(), | ||
| ], | ||
| }, | ||
| ]; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are already using https://github.com/ai/size-limit. I believe it's answering the same problem. Shouldn't we use a single tool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
size limit creates limits. My tool is about showing different sizes.
For it's more important to see these values than moving limits over and over again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it have a mode where it only outputs in the console and doesn't write in the filesystem? I'm wondering about constantly having to commit the snapshot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it the point to show users these numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured out that I can live with that 👍