[ButtonBase] Complete the focusVisible rename #11188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
component: ButtonBase
oliviertassinari
force-pushed
the
focus-visible-complete
branch
from
f5b325b to
493bcf4
Compare
lucaas
reviewed
May 1, 2018
| @@ -121,7 +121,7 @@ declare module "material-ui/ButtonBase/ButtonBase" { | |||
| disableRipple?: boolean, | |||
| disabled?: boolean, | |||
| focusRipple?: boolean, | |||
| keyboardFocusedClassName?: string, | |||
| focusVisibleedClassName?: string, | |||
There was a problem hiding this comment.
@oliviertassinari Looks like there is a typo here, it should be focusVisibleClassName.
There was a problem hiding this comment.
@lucaas Oops, thank you for the review, the flow-typed/npm/material-ui_v1.x.x.js wasn't meant to be changed. It's generated by the flow-typed tools. Do you want to fix it? :)
There was a problem hiding this comment.
Sorry, not sure I can fix it. Was just browsing through the recent changes and stumbled upon it. Good work on the v1 release so far, looks very promising.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rename started with #11090. I should have taken the time to complete it in the first place. This way, we are fully consistent with the spec: https://drafts.csswg.org/selectors-4/#the-focus-visible-pseudo :)
Breaking change