[Snackbar] Static properties for reason string constants #10300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for users to utilize IDE autocompletion for these "reason" passed to `.onRequestClose()`
hai-cea
requested changes
Feb 23, 2018
| @@ -103,6 +103,11 @@ class Snackbar extends Component { | |||
| muiTheme: PropTypes.object.isRequired, | |||
| }; | |||
|
|
|||
| static reasons = { | |||
There was a problem hiding this comment.
Should this be renamed to closeReasons?
There was a problem hiding this comment.
Not sure that's really needed for something as simple as this PR is addressing?
There was a problem hiding this comment.
Also matches the name of the argument given in the documentation..
There was a problem hiding this comment.
http://www.material-ui.com/#/components/snackbar
"The reason parameter can optionally be used to control the response to onRequestClose, for example ignoring clickaway."
hai-cea
approved these changes
Feb 24, 2018
|
Thanks @RavenHursT |
djbuckley
added a commit
to manchesergit/material-ui
that referenced
this pull request
Apr 21, 2018
* commit 'fbfd478b85d02c1fc61ce525bee832f960792bfa': Use selectionEnd instead of selectionEnd to fix caret position issue (mui#10214) Static properties for reason string constants (mui#10300) conditionally apply overlay bkg (mui#9811) fix: handle case where ref is null (mui#10006) [EnhancedButton] Fix onClick event being fired twice on "Enter Key" press (mui#9439) The Popover does not listen to events unless it is open at the moment (mui#9482) [docs] Add v1 recommendation to home page (mui#9727) [Tabs] Add support for inline style override for parent container of InkBar (mui#9598) # Conflicts: # src/Popover/Popover.js # src/Slider/Slider.js # src/Snackbar/Snackbar.js
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for users to utilize IDE autocompletion for these "reason" passed to
.onRequestClose()limiting typos and simplifying refactors.