Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: menu item fires onTouchTap if diabled #7449

Closed
jonashartwig opened this issue Jul 17, 2017 · 3 comments
Closed

BUG: menu item fires onTouchTap if diabled #7449

jonashartwig opened this issue Jul 17, 2017 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@jonashartwig
Copy link

Problem description

When clicking a menu item that is disabled onTouchTap is fired anyways.

alert("what")} />

Versions

  • Material-UI: 0.18.X (latest)
  • React: 15.5
  • Browser: chrome latest
@oliviertassinari oliviertassinari added the duplicate This issue or pull request already exists label Jul 19, 2017
@oliviertassinari
Copy link
Member

Duplicate of #7471.

@oliviertassinari oliviertassinari marked this as a duplicate of #7471 Jul 19, 2017
@jonashartwig
Copy link
Author

yes, it seems i created the item twice. i could not find it so i thought i forgot to submit it :D

@oliviertassinari
Copy link
Member

:)

@jonashartwig jonashartwig mentioned this issue Jul 20, 2017
Merged
oliviertassinari pushed a commit that referenced this issue Jul 21, 2017
@jonashartwig @oliviertassinari
[ListItem] Fix triggers onTouchTap when disabled (#7486)
c759b7d 
* #7449

* #7449 - should fix it

* #7449 - should fix it

* added trailing ,

* made requested changes

* fixed stupid mistake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliviertassinari @jonashartwig