-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change IconButton's property tooltipStyles to tooltipStyle #6778
Comments
@Galti: seems to be a valid suggestion, we would be glad to review a PR! |
I'm using it for styling tooltip on IconButton component.
I don't understand the meaning of "review a PR for it". Can you explain it,
please?
On May 4, 2017 10:53 PM, "Lucas Bento" <[email protected]> wrote:
@Galti <https://github.com/Galti>: where exactly are you using as
tooltipStyles? We would be glad to review a PR for it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6778 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQR2UYwdaep_QPetc1jCRvOB829vcpFnks5r2h6agaJpZM4NQmQT>
.
|
PR - is Pull Request - https://yangsu.github.io/pull-request-tutorial/ Basically @lucasbento asked you if you could maybe fix this issue and submit pull request. If you don't have time, maybe I could help and fix this issue? |
@ivanvs: thanks for explaining it, anyone is welcome to solve it. :) |
Hi, I have created PR - #6792 - that should fix naming issue. Also I have added a test that proves that we have prop with new name and that prop is used in Tooltip component inside button. It wasn't so hard :) Looking forward to your review |
@lucasbento this would change API, and as I understand there is already rewrite in progress. So my PR is rejected. I would suggest you to close this issue then. |
Closing for #2230 |
There are properties style and iconStyle for IconButton component, but for tooltip it is tooltipStyles.
I think it should be changed to tooltipStyle.
The text was updated successfully, but these errors were encountered: