Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change IconButton's property tooltipStyles to tooltipStyle #6778

Closed
Galti opened this issue May 4, 2017 · 7 comments
Closed

Change IconButton's property tooltipStyles to tooltipStyle #6778

Galti opened this issue May 4, 2017 · 7 comments
Labels
component: icon button This is the name of the generic UI component, not the React module!

Comments

@Galti
Copy link

Galti commented May 4, 2017

There are properties style and iconStyle for IconButton component, but for tooltip it is tooltipStyles.
I think it should be changed to tooltipStyle.

@lucasbento lucasbento added component: icon button This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. labels May 4, 2017
@lucasbento
Copy link

@Galti: seems to be a valid suggestion, we would be glad to review a PR!

@Galti
Copy link
Author

Galti commented May 5, 2017 via email

@ivanvs
Copy link

ivanvs commented May 5, 2017

PR - is Pull Request - https://yangsu.github.io/pull-request-tutorial/

Basically @lucasbento asked you if you could maybe fix this issue and submit pull request. If you don't have time, maybe I could help and fix this issue?

@lucasbento
Copy link

@ivanvs: thanks for explaining it, anyone is welcome to solve it. :)

@ivanvs
Copy link

ivanvs commented May 5, 2017

Hi, I have created PR - #6792 - that should fix naming issue. Also I have added a test that proves that we have prop with new name and that prop is used in Tooltip component inside button. It wasn't so hard :)

Looking forward to your review

@ivanvs
Copy link

ivanvs commented May 6, 2017

@lucasbento this would change API, and as I understand there is already rewrite in progress. So my PR is rejected. I would suggest you to close this issue then.

@oliviertassinari oliviertassinari removed the good first issue Great for first contributions. Enable to learn the contribution process. label May 29, 2017
@oliviertassinari
Copy link
Member

Closing for #2230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: icon button This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

4 participants