-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DatePicker/Calendar] Feature Request: Default "firstDayOfWeek" prop for Calendar component #5037
Comments
The default for firstDayOfWeek should be 0 = Sunday. Look at Google examples: |
This ticket was closed as seen in the discussion at #5038. I put default as 1 at the time because that's what it was in the code here: https://github.com/callemall/material-ui/blob/master/src/DatePicker/DatePicker.js#L157 |
@iheidt We are following ISO-8601 for the default, so it is correct. Google examples just show a US localized example. |
Closing for #4787 |
How can I use the Calendar component itself? I have used How can I use this component. I have tried like this: Btw the error I get is this: Thanks is advance |
@hadiMh Could you move the concern to https://github.com/mui-org/material-ui-pickers? |
Description
When reading #3104, as I was looking for something similar, I noticed that the Calendar component, when used on its own and without passing properties, doesn't separate the rows of each week. While I necessarily don't think this is a bug, as the Calendar is used in a way that's unintended, a simple fix would be to provide a default "firstDayOfWeek" property so it's not needed when rendering out an "always there" calendar.
Images & references
The following screenshot below comes up from this code:
The fix, while simple enough, isn't documented anywhere that I could find.
The text was updated successfully, but these errors were encountered: