Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs] Inkbar not appearing under tabs #4860

Closed
kkotwal94 opened this issue Jul 30, 2016 · 7 comments · Fixed by #4635
Closed

[Tabs] Inkbar not appearing under tabs #4860

kkotwal94 opened this issue Jul 30, 2016 · 7 comments · Fixed by #4635
Labels
component: tabs This is the name of the generic UI component, not the React module!

Comments

@kkotwal94
Copy link

The small inkbar won't appear under this tab for some reason, it could be a css thing but I couldn't figure it out, might be missing something I don't know about either, I've been pulling my hairs out but I think the tab height might be too high? I'm not sure honestly and was looking for some help.

I don't know if I've found a bug or its just a styling issue? Maybe someone can confirm?

https://github.com/kkotwal94/MobaRedux/blob/master/app/containers/Navigation.jsx

heres the link to the component, heres the stack overflow question:

http://stackoverflow.com/questions/38669319/reactjs-material-ui-inkbar-not-appearing-for-tabs

@kkotwal94
Copy link
Author

kkotwal94 commented Jul 30, 2016

I found the issue to be my function _handleTabChange for the onchange on tabs, i dont know why yet though, similarly if I add a onactive prop to the tab the inkbar also goes away, anyone find themselves having the same problem?

@kkotwal94 kkotwal94 changed the title Inkbar not appearing under tabs [Bug?]Inkbar not appearing under tabs Aug 1, 2016
@mpontikes mpontikes mentioned this issue Aug 5, 2016
13 tasks
@abelaska
Copy link

abelaska commented Sep 2, 2016

@kkotwal94 any update?

I am having similar trouble. The inkbar is not rendered after all, the element is simply missing and is rendered for example after I move mouse cursor (:hover) to some link that's inline styled by Radium library.

@kkotwal94
Copy link
Author

kkotwal94 commented Sep 2, 2016

I haven't worked on my personal project for a while now, so I haven't had time to coop up a solution. I'm sure it has something to do with adding "ontouchtap" or onClick events to tabs. Try opening up Tab/Tabs.jsx when you can, I think that's what i'll do. I'd probably compare that between a previous version where it was working. Their could've been a huge code change as well which could make a bit difficult. I'll probs mess around with it this weekend.

@oliviertassinari oliviertassinari changed the title [Bug?]Inkbar not appearing under tabs [Tabs] Inkbar not appearing under tabs Sep 16, 2016
@kkotwal94
Copy link
Author

I updated to the latest version, my code hasn't changed I still don't understand why im having the same problem, im following an example like this one: http://www.webpackbin.com/VJDz8cxZz

My code remains the same, I updated react, material ui, and tap event @oliviertassinari

@oliviertassinari
Copy link
Member

@kkotwal94 It could be linked to some external dependencies messing around with the style.

@kkotwal94
Copy link
Author

kkotwal94 commented Nov 23, 2016

Yea possibly, for some reason i haven't thought of that i'll mess around some more

mell0kat added a commit to mell0kat/material-ui that referenced this issue May 8, 2017
@kkotwal94
Copy link
Author

kkotwal94 commented May 24, 2017

Sorry for revisiting this, but for some reason, setting a value for <Tabs> Was what was making my inkbar dissapear, not sure if it is still a issue (i updated material ui in my project and it looks like it is in my project)

             rounded={false}
             style={styles.root}
        >
          {materialIcon}
          <div style={styles.container}>
            <Tabs
              style={styles.tabs}
              //value={this.state.tabIndex}
              onChange={this._handleTabChange}
              inkBarStyle={{backgroundColor:"#FFC107"}}>
              <Tab
                value="8"
                label="DASHBOARD"
                style={styles.tab}
                 />
               <Tab
                 value="7"
                 label="PROFILE"
                 style={styles.tab}
               />
                <Tab
                value="5"
                label="ABOUT"
                style={styles.tab}
                />
            </Tabs>


          </div>

        </Paper>```


@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added component: tabs This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tabs This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants