-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RaisedButton,Use labelColor property,The button will not trigger the hover state #4841
Comments
I've just encountered this bug as well, though I need to say that for me, it didn't work when I specified the color by name (e.g. |
@gyfis That's correct, we don't attempt to map string colours in https://github.com/callemall/material-ui/blob/master/src/utils/colorManipulator.js. Given the move to jss styling in the @gyfis Thanks for following up. |
@mbrookes Thanks for the info! Yeah, it makes sense not to parse colors input in this way. Do you think it would be a good idea to add a general warning about 'adding a non-parseable color to component - this might cause component effects not to work', possibly in the |
We don't have Feel free to submit a PR - should only need a couple of lines. Here's an example warning: https://github.com/callemall/material-ui/blob/master/src/DatePicker/dateUtils.js#L11 |
A warning that fires when the color string format is not in one of the expected formats. It doesn't try to stop the code, but at least warns the user that something is off instead of failing silently. Motivated by issue mui#4841.
I submitted the PR: #5939 |
Problem description
RaisedButton,Use labelColor property,The button will not trigger the hover state
Versions
The text was updated successfully, but these errors were encountered: