Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Support code tabs #39837

Closed
oliviertassinari opened this issue Nov 11, 2023 · 2 comments · Fixed by #40901
Closed

[docs-infra] Support code tabs #39837

oliviertassinari opened this issue Nov 11, 2023 · 2 comments · Fixed by #40901
Assignees
Labels
enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 11, 2023

Summary 💡

A quick placeholder issue for the need to support tabs in the demos. (I couldn't find another issue).

Examples 🌈

https://nivo.rocks/sunburst/

https://www.radix-ui.com/primitives/docs/components/avatar

Motivation 🔦

This could allow us to solve a few problems at once:

  • In the Base UI docs, isolate the source of the component and its uses.
  • In the Material UI Autocomplete demos, moving the long list of countries to a side tab to not clutter the view
  • In the MUI X Data Grid demos, in the cases where we can't use useDemoData because it's key to understand the demo but at the same time there is soo much data that it's hard to follow, we could move that to a side code tab.

A note on the copy button behavior. I would be in favor of having the main one:

to combine the files together when possible

@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer scope: docs-infra Specific to the docs-infra product labels Nov 11, 2023
@danilo-leal
Copy link
Contributor

Heya — how's this different from the one you opened (#38911) a while ago?
We're aware of this and may prioritize it very soon within the docs-infra roadmap!

@danilo-leal danilo-leal removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 12, 2023
@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists and removed scope: docs-infra Specific to the docs-infra product labels Nov 13, 2023
@oliviertassinari oliviertassinari marked this as a duplicate of #38911 Nov 13, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2023
@oliviertassinari oliviertassinari added scope: docs-infra Specific to the docs-infra product enhancement This is not a bug, nor a new feature and removed duplicate This issue or pull request already exists labels Nov 13, 2023
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Nov 13, 2023

@danilo-leal Great point. I think we can treat these two as different issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants