MenuItem does not pass the disabled class

[DavidHenri008]

The MenuItem does not pass the disabled class to the inner ListItem like it does with the dense class name.

• The issue is present in the latest release.
• I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

When a disabled class name is passed to the MenuItem classes property a warning is generated. and the class name is not applied to the disabled menu item.

Expected Behavior 🤔

I would like to be able to pass the disabled class name to the MenuItem classes so it could be relayed to the inner ListItem element, like with the dense class name.

Your Environment 🌎

Tech	Version
Material-UI	v4.9.7
React	v16.13.1

[eps1lon]

That is a general problem with our styling solution and component inheritance. MenuItem implements a different classes prop which means you can't override the classes prop of the ListItem.

Maybe we should start exposing separate props for the classes of the inherited component. This has probably been asked before @oliviertassinari ?

[DavidHenri008]

But it is done for the dense class no?

[oliviertassinari]

@eps1lon I would be in favor of this solution:

• https://github.com/mui-org/material-ui/blob/92a6d9288df1c3dbbece4da16d201d2ef3c04741/packages/material-ui/src/Link/Link.js#L157
• https://github.com/mui-org/material-ui/blob/92a6d9288df1c3dbbece4da16d201d2ef3c04741/packages/material-ui/src/Menu/Menu.js#L249
• https://github.com/mui-org/material-ui/blob/92a6d9288df1c3dbbece4da16d201d2ef3c04741/packages/material-ui-lab/src/SpeedDialAction/SpeedDialAction.js#L197

[eps1lon]

But it is done for the dense class no?

Yeah because Menu handles that class separately. It's not just simply forwarding this class.

A pull request following the approach @oliviertassinari pointed out in #20343 (comment) would be welcome!

[netochaves]

Can I take this?

[DavidHenri008]

Fine for me!
Thanks.